fix: send structured cloudevents json from HTTP sink - #55
Open
dillon-zheng wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event.toString()Content-TypeProblem
The current HTTP sink posts the Java object string form like:
That payload is not a standard CloudEvents wire format and forces downstream receivers to add fragile custom parsing.
Fix
Use the CloudEvents SDK event format provider to serialize the event into structured JSON before sending the HTTP request.
Testing
mvn -Dtest=HttpSinkTest testmvn -DskipTests packagecdevents.hpiand an HTTP receiver capturing the posted request body/header