Fixing: Zipping of directories and files without Parent directory reference - #149
Open
Mahesh-Sivashankaran wants to merge 2 commits into
Open
Fixing: Zipping of directories and files without Parent directory reference#149Mahesh-Sivashankaran wants to merge 2 commits into
Mahesh-Sivashankaran wants to merge 2 commits into
Conversation
jonesbusy
requested changes
Dec 29, 2024
jonesbusy
left a comment
Contributor
There was a problem hiding this comment.
Tests are failing. Which probably indicate a behavior change, which is unwanted
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
Is checked and I don't see any new test here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link: #133
Description:
I had fixed the process of zipping directories and files inside a parent directory into a zip file,
which when unzipped, contains only the files and directory contents inside the parent directory, leaving out the parent directory.
Submitter checklist