Skip to content

Fixing: Zipping of directories and files without Parent directory reference - #149

Open
Mahesh-Sivashankaran wants to merge 2 commits into
jenkinsci:mainfrom
Mahesh-Sivashankaran:main
Open

Fixing: Zipping of directories and files without Parent directory reference#149
Mahesh-Sivashankaran wants to merge 2 commits into
jenkinsci:mainfrom
Mahesh-Sivashankaran:main

Conversation

@Mahesh-Sivashankaran

@Mahesh-Sivashankaran Mahesh-Sivashankaran commented Dec 29, 2024

Copy link
Copy Markdown

Issue Link: #133

Description:
I had fixed the process of zipping directories and files inside a parent directory into a zip file,
which when unzipped, contains only the files and directory contents inside the parent directory, leaving out the parent directory.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Mahesh-Sivashankaran
Mahesh-Sivashankaran requested a review from a team as a code owner December 29, 2024 18:00

@jonesbusy jonesbusy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing. Which probably indicate a behavior change, which is unwanted

  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Is checked and I don't see any new test here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants