Escaped text in the pull title, so it can be safely used in scripts.#430
Merged
benpatterson merged 1 commit intojenkinsci:masterfrom Oct 13, 2016
Merged
Escaped text in the pull title, so it can be safely used in scripts.#430benpatterson merged 1 commit intojenkinsci:masterfrom
benpatterson merged 1 commit intojenkinsci:masterfrom
Conversation
Member
|
Thanks @333fred ! |
nosmo
pushed a commit
to nosmo/ghprb-plugin
that referenced
this pull request
Dec 12, 2018
Escaped text in the pull title, so it can be safely used in scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ghprbPullTitle field not being escaped is causing issues with scripts that attempt to use the title, causing random failures based on the title of the pull request. Further, because the issues are at the script level, you can't work around the issue in the script itself. An example of a bug caused by this is dotnet/roslyn#14480. This ports janinko#426.