No caching and add use of githubapp#837
Open
cdoughty-r7 wants to merge 4 commits intojenkinsci:masterfrom
Open
No caching and add use of githubapp#837cdoughty-r7 wants to merge 4 commits intojenkinsci:masterfrom
cdoughty-r7 wants to merge 4 commits intojenkinsci:masterfrom
Conversation
…repo data.. should still get auth again though
|
What needs to happen for this to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tldr; This allows GHPRB to constantly pull updated credentials and also gives the option to use GithubAppCredentials from github source branch which handles rotating the app installation token every hour.
Why:
Other interest we found:
#812
#813
How:
Benefits:
**
Right now on "mvn install" this fails with spotbugs plugin but packages fine with "mvn package"
Failure starts with:
It was also failing on 2 unit tests originally bc my changes broke what the test was expecting but can't replicate that presently, so I'll leave the tests as long as those don't show up again.