Skip to content

Defaulting to a StringParameterValue #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dannystaple wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Defaulting to a StringParameterValue #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4495b26
Default to the string type entry
dannystaple Oct 23, 2013
5dc91dd
And make that change work
dannystaple Oct 23, 2013
57cf6ed
My last change was ALWAYS defaulting to StringParameterValue
dannystaple Oct 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,14 @@ THE SOFTWARE.
<f:form method="post" action="configSubmit" name="config">
<j:forEach var="parameterValue" items="${paramAction.parameters}">
<j:set var="valuePage" value="${parameterValue.class.simpleName}" />
<st:include it="${parameterValue}"
from="${it}" page="${valuePage}.jelly" />
<j:catch var="ex">
<st:include it="${parameterValue}"
from="${it}" page="${valuePage}.jelly"/>
</j:catch>
<j:if test="${ex != null and ex.toString().contains('No page found')}">
Copy link
Copy Markdown
Member

@oleg-nenashev oleg-nenashev Nov 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this check is OK, because it relies on non-documented text, etc. I suppose it should be implemented in the Java code. I suppose that it can be implemented using small patch in #17

Copy link
Copy Markdown
Author

@dannystaple dannystaple Nov 5, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense - changing the Jelly seemed like a least intrusive patch, but "No page found" is merely human readable text and my code here is treating it as protocol.

<st:include it="${parameterValue}"
from="${it}" page="StringParameterValue.jelly"/>
</j:if>
</j:forEach>
<br/>
<br/>
Expand All @@ -63,4 +69,4 @@ THE SOFTWARE.
</f:form>
</l:main-panel>
</l:layout>
</j:jelly>
</j:jelly>