[JENKINS-41591] Fix pipeline support using TransientActionFactory#55
[JENKINS-41591] Fix pipeline support using TransientActionFactory#55Dohbedoh wants to merge 3 commits intojenkinsci:masterfrom
Conversation
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
Some breaking changes, but it should work well. Some integration tests would not hurt
|
I'm a user of this plugin (thanks, it's been really helpful!) and would love to see this update landed. Sorry I can't add more than my verbal support here. |
Dohbedoh
force-pushed
the
bugfix/JENKINS-41591
branch
from
828fd8c to
2c0da93
Compare
|
Rebased to master. |
|
I'm fine with this. I'll take en extra look this evening, and we'll see if can get it merged. |
|
Hmm.. Can you make the old action invisible (e.g. nulling the url/name/image) and allow the transient action factory to produce a superclass of the RebuildAction (TransientRebuildAction or similar) and allow that one to be visible instead? This way you could ensure only one action is visible, but don't have to write the boring migration stuff (or resave all the builds). |
|
Ping @Dohbedoh |
GLundh
force-pushed
the
master
branch
2 times, most recently
from
370af40 to
316c049
Compare
|
@GLundh Added a transient field to control this. |
5 participants
@reviewbybees
Fix pipeline support, using a
TransientActionFactory<Job>and aTransientActionFactory<Run>.Note: Existing builds may have a duplicate "Build" link in the UI because of the non transient action added by previous version of the plugin. We could add a "migration" method although this will be fixed over time once new builds are being scheduled and old build discarded...