feat: poll manifest file#69
Conversation
if there are many manifest files in the manifest folder, it will only poll the specific file.
francoisferrand
left a comment
francoisferrand
left a comment
There was a problem hiding this comment.
While I understand the idea here, it will not work appropriately when there the manifest include's other manifests : in that case, what the user would expect is that a commit in any of the included manifest will also be found by polling...
As such, I think it would cause more confusion than help, and I would prefer this is not merged.
You could however rework to look at the manifest to list these included manifests, or change the option to make it some include/exclude lists (e.g. poll/ignore some files when polling, similar to git plugin).
(It may be simpler though to rework you job to detect which manifest was modified, and trigger appropriate build accordingly)
| commands.add("git"); | ||
| commands.add("rev-parse"); | ||
| commands.add("HEAD"); | ||
| if (pollManifest && manifestFile != null) { |
There was a problem hiding this comment.
There is always a manifest file, even if none is specified : it defaults to 'default.xml'
If this poll manifest option is enabled, and the name of manifest is not specified, then it should still check the provided manifest.
| @CheckForNull private boolean resetFirst; | ||
| @CheckForNull private boolean cleanFirst; | ||
| @CheckForNull private boolean quiet; | ||
| @CheckForNull private boolean pollManifest; |
There was a problem hiding this comment.
name is misleading, since the manifest is always polled.
maybe pollManifestOnly ?
3 participants
if there are many manifest files in the manifest folder,
it will only poll the specific file.