Parse username in email address#71
Open
chrizchow wants to merge 1 commit into
Open
Conversation
Similar to Git SCM Plugin, getAuthor() should try to parse username using the name in the email address if the user is not found. For example, user "chowmanchun" should be parsed from the email address "chowmanchun@realtek-sg.com".
francoisferrand
requested changes
Jul 11, 2021
francoisferrand
left a comment
There was a problem hiding this comment.
Looking at similar code from git plugin, it seems that code handles more cases (email case, creation of user...)
I think we should do the same; and I would prefer if we would reuse that code instead of copying it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to Git Plugin, getAuthor() should try to parse user using the name in the email address if the user is not found.
For example, if "chowmanchun@realtek-sg.com" cannot be found in the user database, we should try "chowmanchun" from the email address "chowmanchun@realtek-sg.com".