Skip to content

Parse username in email address#71

Open
chrizchow wants to merge 1 commit into
jenkinsci:masterfrom
chrizchow:master
Open

Parse username in email address#71
chrizchow wants to merge 1 commit into
jenkinsci:masterfrom
chrizchow:master

Conversation

@chrizchow

@chrizchow chrizchow commented May 7, 2021

Copy link
Copy Markdown

Similar to Git Plugin, getAuthor() should try to parse user using the name in the email address if the user is not found.
For example, if "chowmanchun@realtek-sg.com" cannot be found in the user database, we should try "chowmanchun" from the email address "chowmanchun@realtek-sg.com".

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Similar to Git SCM Plugin, getAuthor() should try to parse username
using the name in the email address if the user is not found.
For example, user "chowmanchun" should be parsed from the email
address "chowmanchun@realtek-sg.com".

@francoisferrand francoisferrand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at similar code from git plugin, it seems that code handles more cases (email case, creation of user...)

I think we should do the same; and I would prefer if we would reuse that code instead of copying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants