Skip to content

[JENKINS-64150] Fix blank manifest view#76

Closed
abioteau wants to merge 2 commits into
jenkinsci:masterfrom
abioteau:bugfix/blank-manifest-view
Closed

[JENKINS-64150] Fix blank manifest view#76
abioteau wants to merge 2 commits into
jenkinsci:masterfrom
abioteau:bugfix/blank-manifest-view

Conversation

@abioteau

@abioteau abioteau commented Jan 5, 2022

Copy link
Copy Markdown

As describe on #75 and on JENKINS-64150, the repo manifest informations are blanked on existing jobs after restart of Jenkins server on release 1.14.0. It is related to changes made on #62.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@abioteau

abioteau commented Jan 5, 2022

Copy link
Copy Markdown
Author

Hi @francoisferrand, could you have a look on this PR?


private transient Run<?, ?> run;
private transient RevisionState revisionState;
private RevisionState revisionState;

@francoisferrand francoisferrand May 30, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisionState is a large object, which should not be persisted I think; and it will anyway be re-loaded on call to setIndex, hence the transient annotation.
Isn't the @DataBoundSetter annotation enough to fix the problem here?

@abioteau abioteau May 31, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I cannot test my fix.

I add @DataBoundSetter annotation to follow your comment in #75 but ManifestAction is not created from StaplerRequest.bindJSON() or StaplerRequest.bindParameters(), so I don't think setIndex will be call.

So I remove transient annotation to keep revisionState object has setIndex is only call at creation of ManifestAction.

@abioteau

Copy link
Copy Markdown
Author

Issue solved by #82

@abioteau abioteau closed this Sep 13, 2022
@abioteau abioteau deleted the bugfix/blank-manifest-view branch September 13, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants