Skip to content

[JENKINS-68562] Fix Repo checkouts on the built-in node for Windows controllers#81

Open
dwnusbaum wants to merge 2 commits into
jenkinsci:masterfrom
dwnusbaum:JENKINS-68562
Open

[JENKINS-68562] Fix Repo checkouts on the built-in node for Windows controllers#81
dwnusbaum wants to merge 2 commits into
jenkinsci:masterfrom
dwnusbaum:JENKINS-68562

Conversation

@dwnusbaum

@dwnusbaum dwnusbaum commented May 17, 2022

Copy link
Copy Markdown
Member

See JENKINS-68562, which was filed against Git, but the same issue should apply here.

On Windows, Paths.get throws InvalidPathException for URL-like values such as https://whatever. This breaks the fixes for SECURITY-2478 in 3c8e623 for Jenkins controllers running on Windows that perform checkouts on the built-in node.

CC @Pldi23 @rsandell

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

assertEquals(manifestRepositoryUrl, scm.getManifestRepositoryUrl());
}

@Issue("JENKINS-68562")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this test class uses spaces, so I did too, even though RepoScm uses tabs. IDK if there is a particular preference.

@Pldi23 Pldi23 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, identical to git plugin fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants