Handle dorment login configuration in RundeckClientManager#53
Open
norrs wants to merge 2 commits intojenkinsci:masterfrom
Open
Handle dorment login configuration in RundeckClientManager#53norrs wants to merge 2 commits intojenkinsci:masterfrom
norrs wants to merge 2 commits intojenkinsci:masterfrom
Conversation
After upgrading rundeck plugin, I belive the login (read: username for associated password) was removed from the plugin's configuration page. At least I'm unable to see it, and I belive for long time users of this plugin, where it maybe had username stored there once-in-its-lifetime but have migrated over to api token usage instead .. gets bitten by this test case.
before trying to use passwordAuth, ensure both are present. An empty string leaves a valid Secret type, and login information seems to stay from earlier plugin versions and has not been removed by the plugin-upgrade-process. This makes RundeckClientManager work-around the removed login configuration which is no longer available in the plugin (as far as I can see).
867c4b0 to
bd56943
Compare
Author
|
I believe maybe the correct fix is to fix the upgrade process to remove dormant login information .. but I dont know the internals of jenkins.. so this kinda works for me..
I don't see why it complains about And when I fill in and try to remove everything on "Login" and "Password", and ensure I only have "Auth Token" and click save.. I even manage to get stacktrace such as: Anyhow, this PR seems to fix things for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Validate both username and password has value before trying to use passwordAuth.
An empty string leaves a valid Secret type, and login information seems
to stay from earlier plugin versions and has not been removed by the
plugin-upgrade-process. (That's my assumption)