Skip to content

fix(argocd): remove hyphen from clientSecret template #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jennweir merged 1 commit into from
May 9, 2026
Merged

fix(argocd): remove hyphen from clientSecret template #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/platform/argocd/operator/components/argocd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ spec:
name: azure
issuer: <path:projects/1086456784694/secrets/azure_issuer_url#azure_issuer_url>
clientID: <path:projects/1086456784694/secrets/azure_client_id#azure_client_id>
clientSecret: $oidc-azure.azure_client_secret
clientSecret: $oidc.azure_client_secret
# Optional set of OIDC scopes to request. If omitted, defaults to: ["openid", "profile", "email", "groups"]
requestedScopes: ["openid", "profile", "email"]
# Optional set of OIDC claims to request on the ID token.
Expand Down
4 changes: 2 additions & 2 deletions manifests/platform/argocd/overlays/okd/oidc-external-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: external-secrets.io/v1
kind: ExternalSecret
metadata:
name: oidc-azure
name: oidc
namespace: argocd
annotations:
argocd.argoproj.io/sync-wave: "3"
Expand All @@ -11,7 +11,7 @@ spec:
name: gsm-secret-store
kind: SecretStore
target:
name: oidc-azure
name: oidc
creationPolicy: Owner
data:
- secretKey: azure_client_secret
Expand Down
Loading