Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@philip
Copy link

@philip philip commented Dec 20, 2016

Added a Request Body textarea along with a corresponding Content-Type definition.
Code taken directly from the following fork:
https://github.com/taggiasco/resttesttest
Patches in that fork included many other changes, so can't provide a direct link.

… definition.

Code taken directly from the following fork:
  https://github.com/taggiasco/resttesttest
Patches in that fork included many other changes, so can't provide
a direct link.
@philip
Copy link
Author

philip commented Dec 20, 2016

This pull request also helps with Issue #7

@taggiasco
Copy link

Hi,
How do you deal with parameters ? Since you have a body, parameters are ignored for the moment.
In my fork, I added a "buildArguments" which appends the parameters to the URL (only when you have a body). Not sure if it is the right way of doing this, but the request seems to be correctly handled by the test service (https://httpbin.org/put).
Best regards,
Matt

@philip
Copy link
Author

philip commented Dec 21, 2016

@taggiasco Ah, an excellent point, thank you. My attempts to keep the pull request as simple/small as possible missed that fact, and my tests all used headers+body and not parameters. I'll update the pull request at some point.

request body is sent, the parameters are also included.

Still seems to cause issues when using GET + Body, will look into
if that should be allowed and/or handle the error more gracefully.
@philip
Copy link
Author

philip commented Dec 21, 2016

@taggiasco @jeroenooms Okay, this merge request seems fine now. I don't fully understand this topic yet as I'm still learning the ins and outs of REST APIs (and HTTP requests in general).

@bracco23
Copy link

bracco23 commented Oct 19, 2017

Is there any plan to finally merge this and add this functionality?

@philip
Copy link
Author

philip commented Oct 19, 2017

@bracco23 This project is no longer active (no commits in 2+ years) so I doubt it.

@jeroen
Copy link
Owner

jeroen commented Oct 19, 2017

You know you can easily deploy your own version right? It's just static html. You can upload it to anywhere you want and it'll work :)

@philip
Copy link
Author

philip commented Oct 24, 2017

@jeroen True, although it's easier to click a button (download) than worry about applying patches :) But I suspect you'll not merge this PR as to keep https://resttesttest.com/ as is, right? Understandable, of course.

redguyrichard and others added 2 commits April 11, 2020 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants