cfg80211: cookie became an input parameter in 7.3 - #48
Merged
Conversation
cfg80211 now pre-assigns the cookie and passes it by value to remain_on_channel and mgmt_tx (996753804410 + 914781c72813 in wireless-next); the driver must report that value back instead of generating its own. Gate at KERNEL_VERSION(7, 3, 0).
There was a problem hiding this comment.
Pull request overview
Updates the driver’s cfg80211 callback implementations to match the Linux 7.3+ API change where the remain-on-channel and mgmt-tx “cookie” is passed by value (pre-assigned by cfg80211) instead of being returned via a u64 * out-parameter, while preserving the legacy behavior for older kernels.
Changes:
- Adjust
cfg80211_rtw_remain_on_channel()signature for 7.3+ to accept au64cookie input and use it consistently, keeping cookie generation only for <7.3. - Adjust
cfg80211_rtw_mgmt_tx()signature for 7.3+ to accept au64cookie input and stop generating cookies on 7.3+. - Maintain existing version-gated compatibility logic (including the 7.2
rx_addrparameter handling).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux-next converted the remain_on_channel / mgmt_tx cookie from a
u64 *out-param to au64value: cfg80211 pre-assigns it (996753804410) and the ops signatures changed (914781c72813). The driver now echoes the passed value on 7.3+ instead of generating its own (generation stays gated for older kernels); probe_peer / tx_control_port from the same series are not implemented here.Verified:
ioctl_cfg80211.obuilds clean against next-20260824 with the version forced to 7.3.0 (new branch) and against v7.2 (old branch).Note: next still reports
LINUX_VERSION_CODE7.2.0, so the next cells stay red until v7.3-rc1 bumps the version — then they go green by themselves, same as the 7.2rx_addrcase (#38).