Repository navigation
Preflight: commit result without a trailing newline (provenance gate failed every release since 10-08) - #112
Merged
Merged
Conversation
…ce gate failed every release since 2026-10-08) `git rev-parse FETCH_HEAD | tr -d \'\n\'` deletes the characters ' and n, not the newline, so every build's SLSA provenance recorded the source commit as "<sha>\n". The release gate's Conforma policy then failed every release PR: "Material digest ... is not a git commit sha" and "Expected source code reference was not provided" (found live on gitops-boarding-api#41 and #45; the signature itself verified). Introduced when preflight replaced the clone Task on 2026-10-08. Images built before the fix keep the bad provenance; the next build of each app passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug found live: the release gate's
provenancecheck failed on every release PR since 2026-10-08, and the PRs were merged anyway: gitops-boarding-api#41 (staging) and #45 (prod). The signature itself verified. The Conforma policy rejected the provenance:Cause:
stage-preflightwrites the commit result withgit rev-parse FETCH_HEAD | tr -d \\'\\n\\'. In bash that deletes the characters'andn, not the newline, soCHAINS-GIT_COMMITcarried<sha>\\ninto every build's SLSA provenance. Checked locally: the old command keeps the\\n;printf '%s' "$(…)"does not.Fix:
printf '%s' "$(git rev-parse FETCH_HEAD)".After merge: images built before this fix keep the bad provenance, so their release PRs keep failing the gate. Each app's next build passes.
🤖 Generated with Claude Code