Skip to content

Tower UI fixes: one YAML look with Copy, Lambda cards, guardrails red after a bypass, new Ground env steps - #87

Merged
jfillman merged 3 commits into
mainfrom
tower-bugs-1012b
Oct 12, 2026
Merged

jfillman merged 3 commits into
mainfrom
tower-bugs-1012b

Conversation

@jfillman

Copy link
Copy Markdown
Owner

Works through the 2026-10-12 bug list (items 2, 3, 4, 7, 8, 9, 10; items 1, 5 and 6 live in backstage/glidepath).

  • One YAML look (8) + Copy on the PipelineRun YAML (3): every read-only YAML view renders through ui/YamlBlock (keys sky, numbers/booleans amber, line numbers, Copy, line filter): the Pipelines YAML dialog, the committed cicd.yaml, a Rollout topology node, the values form's full/committed values and its examples, and the topology YamlView's YAML mode. Documented in docs/design-system.md.
  • Services cards (2): the footer wraps, so Function · AWS Lambda no longer cuts the owner off.
  • Pull request dialog (9): one link to the PR.
  • Guardrails red after a bypass (7): a PR merged with a failed check draws the Guardrails stage red; the delivery still counts as finished.
  • Pipeline log timestamps (4): archived logs parse the per-line timestamps the Results watcher now collects (gitops-cluster-dev#95, live).
  • New Ground environment (10): the steps link the open onboarding PR and wait on it; the values file is re-read every 45 s until it exists; "Also add a deploy step for it to the pipeline" (default on) so the environment is reachable from CI; the Deployed step says when no pipeline deploys there; Replicas shows the chart default as a placeholder, not a value.

Checks: tsc, 743 tests, lint (0 errors), style ratchet, package build (no chunk cycle).

🤖 Generated with Claude Code

jfillman and others added 3 commits October 12, 2026 12:10
… after a bypass, new Ground env steps

- YAML everywhere goes through one kit piece, ui/YamlBlock (keys sky, numbers amber,
  line numbers, Copy, a line filter): the PipelineRun YAML dialog (it had no Copy),
  the committed cicd.yaml, a Rollout topology node, the values form's full/committed
  values and examples, and the topology YamlView's YAML mode. Five hand-rolled <pre>
  styles gone.
- Services cards: the footer wraps, so "Function · AWS Lambda" no longer cuts the
  owner off; the owner sits right-aligned on its own line when needed.
- Pull request dialog: one link to the PR, not two.
- Deployments DAG: a merge that went ahead with a failed check (GitHub Free cannot
  block it) draws Guardrails red instead of green; the delivery still counts as
  finished, so it does not stay "current" for good.
- Pipeline logs: archived (Tekton Results) logs now carry the watcher's per-line
  timestamps (gitops-cluster-dev#95) and are parsed like live logs.
- Adding a Ground environment: the provisioning steps link the onboarding PR that is
  open (not the oldest merged one) and wait on it; the values file is re-read every
  45 s until it exists; "Also add a deploy step for it to the pipeline" (on by
  default) gives the new environment a deploy step like a Flight one gets a release
  step, and the Deployed step says plainly when no pipeline deploys there. Replicas
  shows the chart default as a placeholder instead of a value the file never set.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…t a blocked merge

The banner said "this blocks the merge, nothing has synced" for a release that
had merged and rolled out with a failed check. The red Guardrails node and its
stage detail carry that; the banner reports the rollout.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@jfillman
jfillman merged commit 2f32085 into main Oct 12, 2026
1 check passed
@jfillman
jfillman deleted the tower-bugs-1012b branch October 12, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant