remove css warning on weasyprint#11606
Merged
Merged
Conversation
Owner
|
|
Owner
|
If I understand correctly, it's the use of the |
Issue
-----
Styles unconditionally emits css that uses screen-only properties.
Paged-media engines (weasyprint, prince, pagedjs) have no viewport
and complain. Fix it to hide these properties from the engines.
Before
------
Building any document with `pandoc --pdf-engine=weasyprint` prints:
WARNING: Ignored `gap: min(4vw, 1.5em)` at 6:32, invalid value.
WARNING: Ignored `overflow-x: auto` at 7:28, unknown property.
After
-----
Same two rules, wrapped in `@media screen { ... }`. HTML browsers
render identically. Print engines skip the block, no warnings.
Fixes: jgm#11524
kbrock
force-pushed
the
screen-scope-columns-css
branch
from
b2f5413 to
1fbf0ea
Compare
Owner
|
thanks! |
Contributor
Author
|
Thank you @jgm have a great weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Styles unconditionally emits css that uses screen-only properties. Paged-media engines (weasyprint, prince, pagedjs) have no viewport and complain. Fix it to hide these properties from the engines.
Before
Building any document with
pandoc --pdf-engine=weasyprintprints:After
Same two rules, wrapped in
@media screen { ... }. HTML browsers render identically. Print engines skip the block, no warnings.Fixes: #11524