Markdown reader: fix quotes in inline notes#11614
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a Markdown reader edge case where inline note contents (^[...]) incorrectly inherited the surrounding quote context, preventing smart quotes inside the note from being parsed as Quoted nodes. It is a targeted parser fix in the Markdown reader with matching regression tests in the reader test suite.
Changes:
- Reset quote context to
NoQuotewhile parsing inline note bodies in the Markdown reader. - Add regression tests for single-quoted and double-quoted inline notes nested inside matching outer quoted spans.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Text/Pandoc/Readers/Markdown.hs |
Wraps inline note body parsing with withQuoteContext NoQuote so note contents are parsed independently of surrounding quote state. |
test/Tests/Readers/Markdown.hs |
Adds smart-punctuation regression tests covering inline notes inside single and double quoted spans. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When parsing an inline note (`^[...]`) inside a quoted span, `stateQuoteContext` was still set to `InSingleQuote`/`InDoubleQuote`, so quotes within notes failed to parse as `Quoted` nodes. Fix this by wrapping the note body parser in `withQuoteContext NoQuote`. Closes jgm#11613.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an inline note (
^[...]) inside a quoted span,stateQuoteContextwas still set toInSingleQuote/InDoubleQuote, meaning that quotes within notes failed to parse asQuotednodes. Fix by wrapping the note body parser inwithQuoteContext NoQuote.Closes #11613.