Fix HP card summary truncation in expanded view#23
Merged
Conversation
The High Priority (4★) card was truncating the summary text to 2 lines with ellipsis even when expanded, because line-clamp-2 was applied inside the expanded detail panel. The Featured (5★) tier did not have this issue. Removed line-clamp-2 from both the summary paragraph and fragment content div in the HP tier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The High Priority (4★) entry card was cutting off the summary text with
...even when expanded. See screenshot — the summary ends with "by utilizing..." instead of showing the full text.Cause
line-clamp-2was applied to the summary<p>and fragment<div>inside the{#if expanded}block of the HP tier. This CSS utility truncates text to 2 lines with an ellipsis. The Featured (5★) tier did not have this class, which is why it showed full summaries.Fix
Removed
line-clamp-2from both elements in the HP tier's expanded detail panel. The full summary and fragment content will now be visible when the card is expanded.