Add Daily News Digest #minor#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
go test ./internal/... ./cmd/knowledgehub -count=1go test ./internal/ai ./internal/engine ./internal/routes -coverprofile=coverage.out -covermode=atomic -count=1(total 90.2%)go test ./... -count=1go vet ./internal/... ./cmd/knowledgehubcd ui && bunx vitest runcd ui && bun run buildcd ui && bun run checkcurrently fails only on pre-existing/unmodified frontend files/config (ui/vite.config.ts,LinkPanel.svelte,QuickAddModal.svelte, plus existing warnings).Proof
CAD-xxxx — Daily News Digest proof
Proof captured from worktree
daily-news-digeston 2026-05-09 against a local PocketBase/Svelte app athttp://127.0.0.1:18090.What is proven
javascript:links; the malicious sample appears as inert text.UI proof
1. Sign-in screen
2. Credentials filled before sign in
3. Feed after sign in, including Daily News navigation
4. Daily News latest digest
Shows the latest digest, controls, sanitized body, internal reference controls, settings, and previous editions.
5. Digest-scoped entry reference modal
Clicking an internal
[[kh-entry:<id>]]reference opens the referenced entry card modal with source, stars, summary, takeaways, and original-article link.6. Settings area before/while editing
7. Settings saved confirmation
API proof
Recorded requests and responses are in
api-proof.md. Highlights:GET /api/daily-news/settingsreturns materialized per-user defaults.PUT /api/daily-news/settingspersists generation time, timezone, enabled state, and extra instructions.GET /api/daily-news/digests/{digestId}returns the proof digest, body Markdown, counts, references, status, and period.GET /api/daily-news/digests/{digestId}/entries/{entryId}returns only a validated digest-scoped referenced entry DTO.POST /api/daily-news/generatereturns202 Acceptedwith a pending job DTO.Self-review
This proof shows the actual Daily News Digest changes present in this worktree: new navigation/page, digest rendering, sanitized Markdown behavior, entry-reference modal, settings API/UI, and manual generate API behavior. The API transcript uses bearer tokens redacted and captures both request intent and responses. The UI screenshots cover each visible state change used in the proof.