Replace Makefile workflow with just#25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
justfilecovering ui/build/dev/release/clean/test.just.maketojust.Verification
just testjust buildjust releasejust release 1.2.3openspec validate replace-make-with-just --strictbefore archivingProof
CAD-xxxx — Replace Make with Just Proof
Summary
This proof shows that this worktree replaced the Makefile workflow with a root
justfile, updated automation to usejust, and preserved build/test/release behavior.Relevant changed files:
justfileadded withui,build,dev,release,clean, andtestrecipes.Makefileremoved..github/workflows/ci.ymland.github/workflows/release.ymlinstall and invokejust.README.mdandAGENTS.mdreferencejustcommands.UI / Operator Proof
There is no product UI change in this feature. The user-visible interface for this change is the developer/operator CLI. Screenshots below show each observable CLI step.
1. Recipe list exposes the replacement command surface
2. Test recipe runs Go tests and coverage
3. Build recipe builds frontend assets, embeds them, and creates the local binary
4. Release recipe accepts an explicit version and creates the expected tarball contents
API Proof
The feature is build tooling, not an application API feature. To prove the
just buildartifact serves the embedded UI correctly, I started the locally built binary and recorded the HTTP request/response for/.Request
Response excerpt
Full captured request/response screenshot:
Verification Commands Run
just --list just test just build just release 1.2.3 tar -tzf build/knowledgehub-linux-amd64.tar.gz KH_DATA_DIR=./proof_data ./build/knowledgehub serve --http=127.0.0.1:18090 curl -i http://127.0.0.1:18090/Self-review
This proof directly demonstrates the changes in this worktree:
just --list.test,build, andreleaserecipes execute successfully.Conclusion: proof is sufficient for a human or another agent to verify the functionality added by this worktree.