fix(security): skip symlinks in discovery to prevent exfiltration#3
Open
cedric-appdirect wants to merge 1 commit into
Open
fix(security): skip symlinks in discovery to prevent exfiltration#3cedric-appdirect wants to merge 1 commit into
cedric-appdirect wants to merge 1 commit into
Conversation
Add three layers of symlink protection to discovery functions: 1. entry.isFile() guard on leaf-file checks in discoverAgents, discoverCommands, and discoverPlugins — prevents reading symlinks disguised as .md/.ts/.js files. 2. !entry.isSymbolicLink() guard on directory traversal in all four discovery functions — prevents following symlink-to-directory into arbitrary filesystem paths. 3. fs.lstatSync() for SKILL.md existence check in discoverSkills — prevents reading a symlinked SKILL.md that points outside the repo. Assisted-by: OpenCode with claude-opus-4-7
cedric-appdirect
force-pushed
the
security/symlink-prevention
branch
from
8899215 to
1ee7c2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three layers of symlink protection to discovery functions:
entry.isFile() guard on leaf-file checks in discoverAgents, discoverCommands, and discoverPlugins — prevents reading symlinks disguised as .md/.ts/.js files.
!entry.isSymbolicLink() guard on directory traversal in all four discovery functions — prevents following symlink-to-directory into arbitrary filesystem paths.
fs.lstatSync() for SKILL.md existence check in discoverSkills — prevents reading a symlinked SKILL.md that points outside the repo. Assisted-by: OpenCode with claude-opus-4-7