fix(security): enforce strict schema validation for agent configs#4
Open
cedric-appdirect wants to merge 1 commit into
Open
fix(security): enforce strict schema validation for agent configs#4cedric-appdirect wants to merge 1 commit into
cedric-appdirect wants to merge 1 commit into
Conversation
Replace .passthrough() with .strict() on AgentConfigSchema. This prevents malicious repos from injecting arbitrary config fields that flow through to OpenCode. Also replaces z.any() in the options field with z.string() for type safety. Breaking change: repos with unknown agent config fields (e.g., for a newer OpenCode version) will now get a parse error instead of silently passing through. Assisted-by: OpenCode with claude-opus-4-7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace .passthrough() with .strict() on AgentConfigSchema. This prevents malicious repos from injecting arbitrary config fields that flow through to OpenCode. Also replaces z.any() in the options field with z.string() for type safety.
This change clearly goes against what the intent seems to have been here:
// Allow unknown keys for forward compatibility. I think it is a more robust strategy to provide a clear expectation of what happen and reduce unexpected/uncontrolled behavior.Breaking change: repos with unknown agent config fields (e.g., for a newer OpenCode version) will now get a parse error instead of silently passing through.