fix(security): sandbox file:// URLs and replace HOME env fallback#9
Open
cedric-appdirect wants to merge 1 commit into
Open
fix(security): sandbox file:// URLs and replace HOME env fallback#9cedric-appdirect wants to merge 1 commit into
cedric-appdirect wants to merge 1 commit into
Conversation
Two related security improvements to git.ts: 1. Sandbox file:// URLs: fileUrlToPath() now restricts paths to the user's home directory by default. Supports tilde expansion (file://~/) and an escape hatch via OPENCODE_REMOTE_CONFIG_ALLOW_PATHS env var for CI, Docker, and shared-install environments. Uses WHATWG URL class for RFC-correct parsing. 2. Replace process.env.HOME || '~' with os.homedir() for reliable home directory resolution across platforms. Breaking change: file:// URLs pointing outside the home directory are now rejected unless OPENCODE_REMOTE_CONFIG_ALLOW_PATHS is set. Assisted-by: OpenCode with claude-opus-4-7 Signed-off-by: Cedric BAIL <cedric.bail@appdirect.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related security improvements to git.ts:
Sandbox file:// URLs: fileUrlToPath() now restricts paths to the user's home directory by default. Supports tilde expansion (file://~/) and an escape hatch via OPENCODE_REMOTE_CONFIG_ALLOW_PATHS env var for CI, Docker, and shared-install environments. Uses WHATWG URL class for RFC-correct parsing.
Replace process.env.HOME || '~' with os.homedir() for reliable home directory resolution across platforms.
Breaking change: file:// URLs pointing outside the home directory are now rejected unless OPENCODE_REMOTE_CONFIG_ALLOW_PATHS is set.