fix(arktype-utils): Adjusts bad values to stop mangling names#23
Merged
fix(arktype-utils): Adjusts bad values to stop mangling names#23
Conversation
🦋 Changeset detectedLatest commit: 96109da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5881d23 to
d9cb66e
Compare
d9cb66e to
96109da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Fixed a bug in the form data parser and removed the
--changedflag from the test:ci script.What changed?
parseKeyPathfunction where it was always using the first character of the key instead of iterating through each character--changedflag from thetest:ciscript in package.json to ensure all tests run during CIHow to test?
pnpm testto verify the form data parser works correctlyWhy make this change?
The form data parser had a critical bug where it was always using the first character of the key (
key[0]) instead of the current character in the iteration (key[i]). This would cause incorrect parsing of form data keys with brackets. Additionally, removing the--changedflag ensures that all tests run during CI, providing better test coverage and preventing potential regressions.