Skip to content

fix(arktype-utils): Adjusts bad values to stop mangling names#23

Merged
jhechtf merged 1 commit intomainfrom
fix/failed-items
Sep 2, 2025
Merged

fix(arktype-utils): Adjusts bad values to stop mangling names#23
jhechtf merged 1 commit intomainfrom
fix/failed-items

Conversation

@jhechtf
Copy link
Copy Markdown
Owner

@jhechtf jhechtf commented Sep 2, 2025

TL;DR

Fixed a bug in the form data parser and removed the --changed flag from the test:ci script.

What changed?

  • Fixed a critical bug in the parseKeyPath function where it was always using the first character of the key instead of iterating through each character
  • Removed the --changed flag from the test:ci script in package.json to ensure all tests run during CI

How to test?

  1. Run pnpm test to verify the form data parser works correctly
  2. Test with a form data key that contains brackets to ensure proper parsing
  3. Verify CI tests run all tests instead of only changed files

Why make this change?

The form data parser had a critical bug where it was always using the first character of the key (key[0]) instead of the current character in the iteration (key[i]). This would cause incorrect parsing of form data keys with brackets. Additionally, removing the --changed flag ensures that all tests run during CI, providing better test coverage and preventing potential regressions.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: 96109da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@jhecht/arktype-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Owner Author

jhechtf commented Sep 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jhechtf jhechtf marked this pull request as ready for review September 2, 2025 03:00
@jhechtf jhechtf merged commit 26a8414 into main Sep 2, 2025
4 checks passed
@jhechtf jhechtf deleted the fix/failed-items branch September 2, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant