Use negotiated content-type to select schema#289
Merged
Conversation
archey347
changed the title
archey347
changed the title
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Adding parameters to content-type (e.g.
json/application; charset=utf8) causes the validation to be completely bypassed.multipart/formin fact requires to have aboundaryoption.The current implementation appears to use the content type provided by the client. This means that if the content type has additional parameters, it doesn't find a schema to validate against, so just uses an empty schema.
By using the content-type from the negotiation (and thus originally derived from the spec), in theory we should always find an appropriate schema.
However, as there's also a bug in the
mojolicious-plugin-openapiwhich means we don't validate file uploads, this will probably break stuff unless deployed at the same time as jhthorsen/mojolicious-plugin-openapi#266 , which might make the packaging/dependency fun.Possibly an an alternative could be to disallow any parameters going into
json-validator, and force the openapi plugin to strip them instead.References
Related: #284,
I think this also fixes jhthorsen/mojolicious-plugin-openapi#261