Polish transcript copy control and terminal landmark - #207
Merged
Merged
Conversation
Owner
Author
|
XO re-gate PASS at exact head Prior format block fixed (tests/test_html.py only). Hosted quality/macos-build/app-e2e/frozen-smoke green. cubic 0 inline comments. Named-ref only. No signing/notarize/release/spend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Walk evidence
The keyless, GPU-less 2026-08-15 walk against exact main
0c646a646423c4eed83f56aafdf2d989bcea5655reproduced both issues in Light and Dark pixels at 1440 px and 390 px. The same 286-segment YouTube transcript was then rendered from this branch for the landing check:scrollWidth == viewportWidth.Validation
uv run pytest— 1,198 passed, 1 skippeduv run ruff check src/podcast_reader/html.py tests/test_html.pyuv run mypy srcnpm test— 453 passednpm run typechecknpm run lintnpx playwright test tests/e2e/artifact-geometry.spec.ts --project=e2e— 26 passedThis PR does not perform signing, notarization, release, or paid operations. It is intentionally left unmerged for independent review.
Summary by cubic
Polishes the transcript export control and terminal landmark naming. Desktop now shows a compact “Copy transcript” button (was a bordered full‑width block); narrow screens keep a full‑width control. The final timeline marker uses “End” for short closing passages; long endings still show an excerpt.
.transcript-export-panel;.transcript-exportbecomes a grid withjustify-items: endand no chrome; the toggle is auto‑width and centered on desktop;@media (max-width: 900px)stretches the toggle to full width and left‑aligns it._timeline_marker_labeland uses it in the rail and in‑flow landmarks to avoid echoing short terminal passages.Written for commit 1ef27ba. Summary will update on new commits.