You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
present failed-job cause and recovery first, with exact diagnostics in a collapsed Technical details control
replace active pipeline wording with terminal copy when a step or job completes
keep complete New-source URL, local-path, and drag-and-drop guidance visible and associated with the source input
give custom-provider validation a stable visible label, human-facing error copy, programmatic association, invalid state, and focus
Tests
npm run typecheck
npm run lint
npm test (458 tests)
npm run build
added Electron browser regressions for collapsed/expanded errors, running-to-done copy, source-guidance geometry at Light/Dark and 100%/125%, and custom-provider accessibility/error behavior
Installed Electron Light/Dark captures at 100%/125% remain host-blocked: Xvfb is unavailable, and the host has Node v22.22.1 rather than Node 24. The focused Electron run was attempted and stopped at launch with Missing X server or $DISPLAY; the PR does not depend on local pixels.
Polishes desktop job and settings guidance for clearer, accessible user-facing behavior. Failed jobs now lead with cause and recovery; terminal step copy appears when a step finishes.
Job failures: Lead with an actionable cause and recovery; keep exact diagnostics in a collapsed Technical details block. Old behavior exposed "{code}: {message}"; new behavior summarizes and defers raw provider text. Adds userFacingJobError; details include code, message, and optional engine detail.
Step progress: Replace active copy with terminal copy when a step finishes without a message (e.g., "Transcription complete."); do not mark warning-only skipped steps complete on job done. Updates deriveProgress with step completion copy.
New-source input: Shortens the placeholder and adds a persistent guidance note associated via aria-describedby; e2e verifies readability across Light/Dark at 100%/125%.
Settings validation: Translate engine validation to human-facing text via settingsErrorMessage, keep stable visible labels, associate errors via aria-describedby, and set focus/aria-invalid on the offending field. Avoid leaking internal field names.
Tests and docs: Extend unit and e2e coverage; add a screenshot drift waiver for this PR. Electron Light/Dark pixel captures remain host‑blocked (no Xvfb, Node 22); this PR does not depend on local pixels.
Independent review of 2b0a089. Requesting changes before merge.
Hosted checks are green (12 success, 2 expected skips). The failed-job card, New-source guidance, Settings label/focus/aria-invalid, and the host pixel bound (#182) look right.
Two cubic P2s are valid against the engine:
settingsErrorMessage treats every custom provider base URL must… string as the HTTPS rule. The engine raises four distinct validate_custom_url errors (hostname, credentials, query/fragment, scheme). Hostname/credentials/query currently get the scheme sentence. Narrow the HTTPS match and give the other three their own human copy, or fall through. Tests should cover all four engine strings.
When a job is done, deriveProgress marks every seen step complete and stamps canned “complete” copy. Skipped diarization/chapters are warning-only (no step_finished) and would read as finished next to the skip warning. Only finished steps should get terminal-complete copy. Add a warning-only + job-done test.
Please push the fixes to this named ref and re-surface the new head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
npm run typechecknpm run lintnpm test(458 tests)npm run buildInstalled Electron Light/Dark captures at 100%/125% remain host-blocked: Xvfb is unavailable, and the host has Node v22.22.1 rather than Node 24. The focused Electron run was attempted and stopped at launch with
Missing X server or $DISPLAY; the PR does not depend on local pixels.Closes #202
Closes #203
Closes #204
Closes #205
Summary by cubic
Polishes desktop job and settings guidance for clearer, accessible user-facing behavior. Failed jobs now lead with cause and recovery; terminal step copy appears when a step finishes.
userFacingJobError; details include code, message, and optional engine detail.deriveProgresswith step completion copy.aria-describedby; e2e verifies readability across Light/Dark at 100%/125%.settingsErrorMessage, keep stable visible labels, associate errors viaaria-describedby, and set focus/aria-invalidon the offending field. Avoid leaking internal field names.Addresses #202, #203, #204, #205
Review focus
Written for commit fe82eed. Summary will update on new commits.