Skip to content

Fix: handle space in things url #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebastienElet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: handle space in things url #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ async function openThingsURL(url: string): Promise<void> {
}
}

// URLSearchParams encodes spaces as '+', but Things URL scheme expects '%20'
function buildThingsQueryString(params: URLSearchParams): string {
return params.toString().replace(/\+/g, "%20");
}

server.tool(
"add-todo",
{
Expand Down Expand Up @@ -124,7 +129,7 @@ server.tool(
if (params["completion-date"])
urlParams.set("completion-date", params["completion-date"]);

const url = `things:///add?${urlParams.toString()}`;
const url = `things:///add?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

const todoName = params.titles
Expand Down Expand Up @@ -212,7 +217,7 @@ server.tool(
if (params["completion-date"])
urlParams.set("completion-date", params["completion-date"]);

const url = `things:///add-project?${urlParams.toString()}`;
const url = `things:///add-project?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

return {
Expand Down Expand Up @@ -337,7 +342,7 @@ server.tool(
if (params["completion-date"])
urlParams.set("completion-date", params["completion-date"]);

const url = `things:///update?${urlParams.toString()}`;
const url = `things:///update?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

return {
Expand Down Expand Up @@ -434,7 +439,7 @@ server.tool(
if (params["completion-date"])
urlParams.set("completion-date", params["completion-date"]);

const url = `things:///update-project?${urlParams.toString()}`;
const url = `things:///update-project?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

return {
Expand Down Expand Up @@ -476,7 +481,7 @@ server.tool(
urlParams.set("filter", params.filter.join(","));
}

const url = `things:///show?${urlParams.toString()}`;
const url = `things:///show?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

const target = params.id || params.query || "Things";
Expand All @@ -500,7 +505,7 @@ server.tool(
const urlParams = new URLSearchParams();
if (params.query) urlParams.set("query", params.query);

const url = `things:///search?${urlParams.toString()}`;
const url = `things:///search?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

return {
Expand Down Expand Up @@ -564,7 +569,7 @@ server.tool(
urlParams.set("reveal", params.reveal.toString());
}

const url = `things:///json?${urlParams.toString()}`;
const url = `things:///json?${buildThingsQueryString(urlParams)}`;
await openThingsURL(url);

return {
Expand Down