Rename SConscript to SConscript.py#2
Open
reza3320 wants to merge 1 commit into
Open
Conversation
Owner
|
While the file is a Python script, the build system's documentation lists the name without the .py ending as the default customary name. I've seen it without .py in other projects, too. Why do you think it should be changed? That may sound a bit combative, but I'm not yet seeing a reason myself and am curious about what I missed. Also, I did just push a commit that changes SConstruct to help out another user. That messes with your other pull request. Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.