fix(gallery): handle scheme-relative og:url in getImageJSON - #27
Merged
Conversation
Hugo emits a scheme-relative Permalink ("//host/path") when baseURL is
unset, which is the case for plain `hugo server` (baseURL is normally
injected at deploy time via `-b`). new URL() rejects a scheme-relative
string as a base, throwing synchronously and surfacing "Couldn't load
images." on every _default-layout page in local dev.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PgXHXLyhCD8mRjE5GsJ3We
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getImageJSON()built theindex.jsonfetch URL from theog:urlmeta tag vianew URL('index.json', ogUrl). When Hugo'sbaseURLis unset (the normal case for localhugo server— prod injects it at deploy time via-b),.Permalinkrenders scheme-relative (//host/path), whichURL()rejects as an invalid base and throws synchronously.createResource(getImageJSON)promise, so every_default-layout page (the scatter gallery) showed theCouldn't load images.fallback in local dev.og:urlcontent starts with//, prepend the current page'swindow.location.protocolbefore using it as the URL base.Test plan
pnpm lint:check/ prettier clean on the changed filepnpm buildcompletes cleanphotography-websitesite (hugo serverwith no-b), confirmedog:urlrenders scheme-relative and the page shows the fallbackindex.jsonendpoint returns 200🤖 Generated with Claude Code
https://claude.ai/code/session_01PgXHXLyhCD8mRjE5GsJ3We