Add remaining market data test coverage from review follow-ups - #4
Merged
Merged
Conversation
- Add SSE integration tests for stream.py by driving _generate_events directly with a fake Request, since both httpx.ASGITransport and FastAPI's TestClient deadlock against this endpoint's unbounded while-True/disconnect-driven loop (confirmed via faulthandler). Coverage for stream.py goes from 31% to 94%. - Add a PriceCache concurrent-writers test (8 threads x 200 updates) asserting the version counter exactly matches, to catch lost updates under real thread interleaving. - Add a full 10-ticker GBMSimulator test covering the mixed tech/finance/TSLA correlation matrix, not just the 1-2 ticker cases. - Add httpx as a dev dependency for ASGI testing. Overall coverage: 91% -> 97%, 84/84 tests passing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011jXykWYaYoRkBpojjASfru
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments or approval blockers were identified.
Pull request overview
Adds remaining market-data test coverage, raising reported coverage from 91% to 97%.
Changes:
- Added SSE router and event-generation tests.
- Added concurrent
PriceCacheand full 10-ticker simulator tests. - Added and locked
httpxas a development dependency.
File summaries
| File | Description |
|---|---|
planning/MARKET_DATA_REVIEW.md |
Documents coverage and verification results. |
backend/uv.lock |
Locks httpx and transitive packages. |
backend/tests/market/test_stream.py |
Tests SSE routing and event generation. |
backend/tests/market/test_simulator.py |
Tests the full ticker set. |
backend/tests/market/test_cache.py |
Tests concurrent cache updates. |
backend/pyproject.toml |
Adds httpx to dev dependencies. |
Review details
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall coverage: 91% -> 97%, 84/84 tests passing.
Claude-Session: https://claude.ai/code/session_011jXykWYaYoRkBpojjASfru