fix: unbreak the Build workflow on main - #5
Merged
Conversation
MSVC treated "*/*" in the doc comment as end-of-comment and failed the build. Co-authored-by: domibuilds <jkr-137@users.noreply.github.com>
jkr-137
marked this pull request as ready for review
August 8, 2026 18:29
PluginUtils.h uses ImRect; without imgui.h MSVC fails that TU after the Http.h comment fix unblocked the build. Co-authored-by: domibuilds <jkr-137@users.noreply.github.com>
The gate never passed: NamespaceIndentation was None while every file indents inside namespaces. Pinning clang-format keeps the check from drifting with the runner image's LLVM. Co-authored-by: domibuilds <jkr-137@users.noreply.github.com>
Co-authored-by: domibuilds <jkr-137@users.noreply.github.com>
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three failures were stacked behind each other on
main; each one only became visible once the previous was fixed.src/Http.h: the doc comment contained*/inside a/** … */block ("*/*"), so MSVC ended the comment early andgwdash::http::Getdisappeared.src/TradePresets.cpp: includes<PluginUtils.h>without<imgui.h>first, so theImRectin Toolbox's header failed to parse in that translation unit..clang-formatsetNamespaceIndentation: Nonewhile every file indents inside namespaces, so the check could never pass. Config now matches the code, the remaining drift is formatted, and the clang-format version is pinned so the gate does not move with the runner image.Test plan
maingoes green