Skip to content

fix TODO and use Log mechanism to report table-design and runtime #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjanssen2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix TODO and use Log mechanism to report table-design and runtime #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/gapc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,23 +368,24 @@ class Main {
if (opts.approx_table_design) {
grammar->approx_table_conf();
}
// TODO(sjanssen): better write message to Log instance, instead of
// std::cout directly!
if (Log::instance()->is_verbose()) {
std::cout << "The following non-terminals will be tabulated (%name "
<< "indicates linear table, %name% indicates constant tables):\n ";
grammar->put_table_conf(std::cout);
std::cout << "\n\n";
std::cout << "resulting in an estimated runtime of:\n ";
std::cout << grammar->runtime() << '\n';
}

// provide user with information about table design and runtime
std::ostringstream message;
message << "The following non-terminals will be tabulated (%name "
<< "indicates linear table, %name% indicates constant"
<< " tables):\n ";
grammar->put_table_conf(message);
message << "\n\n"
<< "resulting in an estimated runtime of:\n "
<< grammar->runtime() << '\n';
Log::instance()->normalMessage(message.str());

// After the table configuration is generated, check for
// suboptimal designs and present a message to the user.
driver.ast.warn_user_table_conf_suboptimal();

// find what type of input is read
// chars, sequence of ints etc.
// find what type of input is read
// chars, sequence of ints etc.
driver.ast.derive_temp_alphabet();

r = driver.ast.check_signature();
Expand Down