Codex/oss eval improvements#75
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e16e591588
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const devspace = current.devspace || {}; | ||
| const screenshotUrl = currentMeta["shipguard/screenshotProxyUrl"] || current.screenshotProxyUrl; | ||
| if (screenshotUrl) { | ||
| screenshotEl.src = screenshotUrl + "?ts=" + Date.now(); |
There was a problem hiding this comment.
When Devspace runs with bearer auth, screenshotProxyUrl already contains the required ?view=<token> query. Appending another ?ts= turns it into ?view=<token>?ts=..., so has_screenshot_view_token() compares the wrong value and the widget image request is rejected with 401. Use &ts= when a query is already present or build the URL with URLSearchParams.
Useful? React with 👍 / 👎.
| for match in surface.get("source_matches", []): | ||
| if isinstance(match, dict) and match.get("file"): | ||
| files.append(str(match["file"])) | ||
| files.extend(str(path) for path in surface.get("project_files", []) if path) |
There was a problem hiding this comment.
For storekit-commerce plans, surface["project_files"] contains dictionaries like {file: ..., kind: ...}, so this appends a Python dict literal into ownerFiles and the Markdown edit boundary instead of just DemoProducts.storekit. That makes the generated Codex plan contain a non-existent path; pull item["file"] the same way the plist and entitlement evidence does.
Useful? React with 👍 / 👎.
4075e07 to
81e28e5
Compare
1 participant
No description provided.