Conversation
eric-j-sanders
suggested changes
Mar 18, 2026
|
|
||
| # Load the genotype matrix for SNP rs1861 with additive coding | ||
| geno_subset <- fread("./02_activities/data/geno.additiveA1.raw") | ||
| geno_subset=na.omit(geno_subset) |
There was a problem hiding this comment.
This line will throw away samples even if they were genotyped for rs1861, just because they are missing genotype values for other SNPs that aren't relevant. So you end up fitting a model on fewer SNPs than you could have.
eric-j-sanders
approved these changes
Mar 20, 2026
eric-j-sanders
left a comment
eric-j-sanders
left a comment
There was a problem hiding this comment.
Thank you for the timely fix! Assignment complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding the code and answers for assignment 1
What did you learn from the changes you have made?
How to account for different genetic models (recessive, additive, dominant)
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist