Conversation
The mixed indentation and 'break after expression' formatting in this code makes it a bit of a landmine, and is causing a large brick of warnings with various compilers and other tools. Adding explicit bracketing and reformatting cases to make code path more explicit, as well as fixing spaces-vs-tab indentation issues due to having to re-indent this function.
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=======================================
Coverage 97.49% 97.49%
=======================================
Files 2 2
Lines 599 599
=======================================
Hits 584 584
Misses 15 15Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the ioquake3 pull request by WolfWings: ioquake/ioq3#255
The mixed indentation and 'break after expression' formatting in this
code makes it a bit of a landmine, and is causing a large brick of
warnings with various compilers and other tools. Adding explicit
bracketing and reformatting cases to make code path more explicit, as
well as fixing spaces-vs-tab indentation issues due to having to
re-indent this function.