fix: align VS Code settings with config keys and reject unknown fields - #56
Merged
Merged
Conversation
…nitionFiles - server dropped excludeFiles, so the setting had no effect - keep lookupFiles as deprecated alias
- still ignored when cvk.json exists
- still allow $schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VS Code extension still sends
excludeFiles, which the server dropped in favor ofinclude. The server ignores it silently:cvk.excludeFileswithcvk.includeand addcvk.definitionFilesin the VS Code extensioncvk.lookupFilesas deprecated in favor ofcvk.definitionFilesinitializationOptionsas a config error instead of dropping themcvk.json(c), except$schema