fix: strip nested brands in PayloadOf - #49
Merged
Merged
Conversation
- `Val.unwrap` returns it too, so seal each nested Val before sealing the unwrapped payload again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PayloadOfstopped at a nested Val, so a handler returningPayloadOf<Order>still sentMoney's brand to the client:Recto its payload inPayloadOfVal.unwrapreturnsPayloadOf<V>, so its nested Vals are plain data too, as they are at run timeCode that stops compiling
The old types claimed a brand the value never had, so these relied on the bug:
Order(Val.unwrap(order))andVal.of(Val.unwrap(order)), when the payload holds a nested Val. Seal each nested Val first:Order({ ...raw, total: Money(raw.total) })Patch<PayloadOf<V>>passed topatch. UsePatch<SeedOf<V>>