Skip to content

fix(results): reject uppercase primary bundles - #1457

Closed
joeharris76 wants to merge 1 commit into
developfrom
fix/pr1444-uppercase-primary-validation-bypass-20260801
Closed

fix(results): reject uppercase primary bundles#1457
joeharris76 wants to merge 1 commit into
developfrom
fix/pr1444-uppercase-primary-validation-bypass-20260801

Conversation

@joeharris76

Copy link
Copy Markdown
Owner

Summary

  • require primary result bundles to use the lowercase .json extension recognized by the submission-validation workflow
  • preserve case-insensitive rejection of companion bundles and manifest files
  • cover validation, corpus inventory generation, and Results Explorer ingestion against uppercase-primary bypasses

Context

Follow-up to the unresolved P1 review finding on #1444: an uppercase primary such as result.JSON could bypass the workflow's lowercase *.json validation pathspec while still being ingested downstream.

Verification

  • uv run -- python -m pytest -n 0 tests/unit/scripts/test_validate_submission.py tests/unit/scripts/test_generate_corpus_inventory.py tests/unit/scripts/explorer_pipeline/test_pipeline.py -k "uppercase_primaries" -q
  • uv run -- python -m pytest -n 0 tests -k "bundle or submission or inventory" -q
  • cd results-explorer && npm run typecheck && npm test
  • uv run -- python -m pytest -n 0 -m fast -q
  • PYTEST_ADDOPTS='-n 0' make pr-preflight

Closes the post-merge review follow-up tracked by pr1444-uppercase-primary-validation-bypass-20260801-2.

@joeharris76
joeharris76 enabled auto-merge (squash) August 1, 2026 23:36
@joeharris76

Copy link
Copy Markdown
Owner Author

Closing as superseded by merged #1449. That PR implemented the reviewer-approved case-insensitive workflow fix and resolved the original #1444 P1 thread; this branch would unnecessarily narrow the accepted bundle contract after that repair.

@joeharris76 joeharris76 closed this Aug 1, 2026
auto-merge was automatically disabled August 1, 2026 23:36

Pull request was closed

@joeharris76
joeharris76 deleted the fix/pr1444-uppercase-primary-validation-bypass-20260801 branch August 1, 2026 23:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5ddbc943d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchbox/validation/bundle.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant