Global Setting 154 ("Ins/Outs" => "Return Type"): change from Kind::Flag to Kind::Choice - #14
Merged
Conversation
…lag to Kind::Choice cargo run -p fretwire-cli -- setting-get 154 154 = 1 [int]
john-baxter-dev
added a commit
that referenced
this pull request
Aug 26, 2026
The table was the only place PR #14 changed. The mock backend still held a bool with flag labels, docs/protocol.md still said `bool`, and the worksheet still listed it as a flag to check. Labels unchanged — a dump prints the value, so 0 Return / 1 Aux In is what the original diff showed. Only the type was wrong. Option count still unknown.
john-baxter-dev
added a commit
that referenced
this pull request
Aug 26, 2026
Robert's pass filled Footswitches, EXP Pedals and Displays and left the table at 53. Four things it didn't touch: - The mock still listed id 12 in the unidentified tier, which PR #16 names. All 19 are mirrored now; globals-mock.mjs goes 34 -> 53. - 135 is identified and unplaced in MENU_ORDER, so it draws at the foot of MIDI/Tempo. Left there rather than guessed, and named in a test so the next one fails instead of sorting last quietly. - Flag vs Choice is the wire type, not a style, and the batch mixes them correctly. Noted on Kind so nobody tidies it into consistency — that mistake is what PR #14 fixed. - Module doc counts, and the fact that 54 identified is not 54 answering on a Stomp. _TODO-settings-discovery.md is answered and retired. What it still wants moves to _TODO-settings-names.md: whether any of the 19 refuse on a Stomp, the 95/96/68/69 section re-check, and 135's row number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to discussion in #12 (comment) ;
fretwire-clireports a returned type ofintrather thanbool