Add getValidationError that returns error message instead of logging#161
Open
johnameyer wants to merge 2 commits intomasterfrom
Open
Add getValidationError that returns error message instead of logging#161johnameyer wants to merge 2 commits intomasterfrom
johnameyer wants to merge 2 commits intomasterfrom
Conversation
|
62e88ac to
ace34ee
Compare
ace34ee to
a59b892
Compare
Each lib's tsconfig extends the root tsconfig which has declarationMap: true, but without rootDir TypeScript infers it from the monorepo root during builds in temp directories, emitting absolute paths in .d.ts declaration map files. Setting rootDir: ./src in each lib ensures relative paths are emitted. Also update packageManager from pnpm@9.0.1 to pnpm@10.0.0 to match CI environment and fix rxjs not being installed during git dep prepack. Fix spec using old validateEvent function API - now uses transform instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
030df34 to
0f5be7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.