fix: resolve Highlightr Bundle.module in packaged .app (editor crash) - #2
Merged
johnfkoo951 merged 1 commit intoJun 27, 2026
Conversation
PR johnfkoo951#1 shipped the SPM resource bundle in Contents/Resources, but the swift-build Bundle.module accessor looks at the .app root (unsignable) and a baked .build path (absent on user machines), never Contents/Resources — so source/split editor render still traps with SIGTRAP on 1.4.7. - package_app.sh: repoint the baked fallback path to the shipped Contents/Resources bundle before codesign (scripts/fix-highlightr-bundle.py). - FIX_FOR_CLAUDE_CODE.md: root cause, reproduce, fix options, regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
johnfkoo951
added a commit
that referenced
this pull request
Jun 27, 2026
) 1.4.7 as published still crashed for users: the copied bundle landed in Contents/Resources, but Highlightr's generated Bundle.module accessor only checks the .app root and a baked .build path — never Contents/Resources. PR #2 (fix-highlightr-bundle.py) repoints the baked path to the shipped bundle before codesign. This bump ships that fix to users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1 shipped the SPM resource bundle in Contents/Resources, but the swift-build Bundle.module accessor looks at the .app root (unsignable) and a baked .build path (absent on user machines), never Contents/Resources — so source/split editor render still traps with SIGTRAP on 1.4.7.