Open
Conversation
In many applications, a quick button is dedicated to copy the link. This PR adds this so the user can skip the native share composent. NOT TESTED ON REAL DEVICES AND ON IOS It's still room for improvement. I believe there's no native way to add a toast message "Text copied to clipboard" to iOS, so I used an alert, not sure how it renders. To workaround this, we could add the dependency "react-native-toast-message" ? Also, it would be great to change temporarily the copy link button to a checkmark with a "Copied!" label, to make it even more clear it's copied. Also, maybe close the share modal after clicking since it's a quick way to copy the link ? Idk, some apps do this, others don't. Fixes joinloops#77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many applications, a quick button is dedicated to copy the link. This PR adds this so the user can skip the native share composent.
NOT TESTED ON REAL DEVICES AND ON IOS
It's still room for improvement. I believe there's no native way to add a toast message "Text copied to clipboard" to iOS, so I used an alert, not sure how it renders. To workaround this, we could add the dependency "react-native-toast-message" ?
Also, it would be great to change temporarily the copy link button to a checkmark with a "Copied!" label, to make it even more clear it's copied.
Also, maybe close the share modal after clicking since it's a quick way to copy the link ? Idk, some apps do this, others don't.
Fixes #77