refactor: rename direction to address, inline the last SQL files - #46
Merged
Merged
Conversation
Three leftovers from when the project had a single benchmark, all of them things a reader notices before they read any logic. - `direction VARCHAR(200)` was a literal translation of "direccion". In English `direction` means heading, not domicile. The schema is the first file most people open, so the column is now `address`. - `queries/query_1.sql` and `query_2.sql` were generically named and loaded only by select_star, while the other three benchmarks declared their SQL inline. The inconsistency had no reason behind it — for one-line queries the file indirection buys nothing, so all four now read the same way and the directory is gone along with QUERIES_DIR and the _get_query helper. - `QUERY_1_NAME` and `QUERY_2_NAME` put one benchmark's display labels in global config. They now live in select_star.py next to the queries they name, as LABEL_ALL_COLUMNS and LABEL_THREE_COLUMNS. No behaviour change. Verified end to end against a fresh compose stack: all four benchmarks return 200 with a chart, and the seeded schema reports the renamed column. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014abw4B6YUf54giaEyPQpbo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three leftovers from when the project had a single benchmark. All cosmetic, but all of them things a reader hits before reaching any logic.
direction VARCHAR(200)→addressdirectionmeans heading, not domicile. The schema is the first file most people open.queries/query_1.sql,query_2.sql→ inlineselect_starwhile the other three benchmarks declared their SQL inline. The inconsistency had no reason behind it; for one-line queries the file indirection buys nothing. Directory removed along withQUERIES_DIRand the_get_queryhelper.QUERY_1_NAME/QUERY_2_NAME→LABEL_*inselect_star.pyNo behaviour change.
Verification
ruff check .clean, 54 tests (was 55 —test_queries_dirtested a directory that no longer exists), 93% coverage.address, so the rename is guarded rather than assumed. Watched it fail withUndefinedColumnbefore making the change.🤖 Generated with Claude Code
https://claude.ai/code/session_014abw4B6YUf54giaEyPQpbo