I'm Andrew Goode I worked with @ladypineapple#7
Open
akgoode wants to merge 1 commit intojonathanbarton:masterfrom
Open
I'm Andrew Goode I worked with @ladypineapple#7akgoode wants to merge 1 commit intojonathanbarton:masterfrom
akgoode wants to merge 1 commit intojonathanbarton:masterfrom
Conversation
Maura found the rounding bug and I found the solution. Solution is to add the new amount first and then round the result instead of trying to do both operations in place.
akgoode
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ladypineapple found the rounding bug
and I found the solution.
Solution is to add the new amount first and then round
the result instead of trying to do both operations in place.