Addressing warning messages when using test_sharp_null()#17
Open
MikkelVembye wants to merge 2 commits into
Open
Addressing warning messages when using test_sharp_null()#17MikkelVembye wants to merge 2 commits into
MikkelVembye wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jonathan,
Thank you sincerely for a wonderful paper and software package. My team and I are very much looking forward to using your work.
While testing the package, we encountered the following warning messages:
Warning messages: 1: In library(package, lib.loc = lib.loc, character.only = TRUE, logical.return = TRUE, : there is no package called ‘lpinfer’ 2:cross_df()was deprecated in purrr 1.0.0. ℹ Please usetidyr::expand_grid()instead. ℹ See <[https://github.com/tidyverse/purrr/issues/768](vscode-file://vscode-app/c:/Users/B199526/AppData/Local/Programs/Positron/resources/app/out/vs/code/electron-browser/workbench/workbench.html#)>. ℹ The deprecated feature was likely used in the TestMechs package. Please report the issue to the authors. This warning is displayed once every 8 hours. Calllifecycle::last_lifecycle_warnings()to see where this warning was generated. 3:cross()was deprecated in purrr 1.0.0. ℹ Please usetidyr::expand_grid()instead. ℹ See <[https://github.com/tidyverse/purrr/issues/768](vscode-file://vscode-app/c:/Users/B199526/AppData/Local/Programs/Positron/resources/app/out/vs/code/electron-browser/workbench/workbench.html#)>. ℹ The deprecated feature was likely used in the purrr package. Please report the issue at <[https://github.com/tidyverse/purrr/issues](vscode-file://vscode-app/c:/Users/B199526/AppData/Local/Programs/Positron/resources/app/out/vs/code/electron-browser/workbench/workbench.html#)>.These warnings caused some confusion among my colleagues, particularly those who primarily use Stata. To accommodate this, I have added lpinfer to Remotes in the DESCRIPTION file. In addition, I have updated purrr::cross_df() to tidyr::expand_grid() and added tidyr to Imports.
All the best to you, and once again, thank you.
Best wishes,
Mikkel