Conversation
Owner
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
we had a situation where an extension would render a specific product based on the (real) URL, and set the og-tags accordingly in the
beforeHeaderCreationslot. This was working fine until you added another querystring parameter that was not captured by the cHash; then the og-tags from the last "valid" URL were taken. We solved this by overridingpage.669with aUSER_INT, and thought it would be a good idea to make this the default behaviour.Anyway if you think this is not appropriate performance-wise, I might open an issue instead -- maybe we could find a more convenient way to make this configurable.
:-)All the best
Sebastian