Fix "This PR is dumb" classification - add test case and training data - #219
Merged
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
… data Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Can we add a case for
Fix "This PR is dumb" classification - add test case and training data
Jul 25, 2025
This PR is dumb
jonathanpeppers
marked this pull request as ready for review
July 25, 2025 15:30
jonathanpeppers
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phrase "This PR is dumb" was not being flagged as potentially problematic and should be classified as negative.
Before this fix:
After this fix:
Changes made:
"This PR is dumb"toonnxjs/tests/test_cases.jsoncomments/classified.csv:The fix follows the established pattern for heuristics improvements by using verbatim text in test cases and similar but not identical text in training data. All 219 tests pass including the new test case.
Fixes #218.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.