VASTAds Constructor fix for new Chrome#20
Open
Fire-Brand wants to merge 2 commits intojonhoo:masterfrom
Fire-Brand:master
Open
VASTAds Constructor fix for new Chrome#20Fire-Brand wants to merge 2 commits intojonhoo:masterfrom Fire-Brand:master
Fire-Brand wants to merge 2 commits intojonhoo:masterfrom
Fire-Brand:master
Conversation
Owner
|
Could you please split this into two PRs -- one for each feature? I'm happy to merge both. |
Author
|
I remember only sending one PR, the second one was just a commit, don't know why it popped up in this PR. I'm not sure how to resend as 2 separate PRs, advice? |
Owner
|
It's because you made this change after already having committed your You should now have two new branches in your fork: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in issue #19 this fixes the
getElementsByTagNameNScall with root.namespaceURI to call it with "*" .